chrisdutz commented on code in PR #12914:
URL: https://github.com/apache/iotdb/pull/12914#discussion_r1682363224
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -256,6 +276,24 @@ public TDataNodeRegisterResp
registerDataNode(TDataNodeRegisterReq req) {
@Override
public TDataNodeRestartResp restartDataNode(TDataNodeRestartReq req) {
+ // If the remote server is configured to bind to all ip addresses
(0.0.0.0),
+ // update the request to use the remote address we got this request from.
+ if ((req.dataNodeConfiguration.getLocation() != null)
Review Comment:
If you ask me, I think handling 2 bits of information instead of only 1
would be the better solution.
Currently a user runs "show datanodes" he possibly gets a list of "0.0.0.0"
which helps him nothing. From a user perspective I think a list of
public-facing ips would be ideal (So returing the list of real IPs that a user
can connect to the RPC server to) ... but on the other side we also have the
internal network and as far as I understood it, the Config Node(s) use the
internal rpc to do the cluster management (These can be on completely isolated
newtorks, that a user can't even reach). So having a list of external rpc
addresses per node and one internal rpc address seems the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
