OneSizeFitsQuorum commented on code in PR #13440:
URL: https://github.com/apache/iotdb/pull/13440#discussion_r1759718756
##########
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -37,11 +37,12 @@ struct TGlobalConfig {
5: required i64 timePartitionInterval
6: required string readConsistencyLevel
7: required double diskSpaceWarningThreshold
- 8: optional string timestampPrecision
- 9: optional string schemaEngineMode
- 10: optional i32 tagAttributeTotalSize
- 11: optional bool isEnterprise
- 12: optional i64 timePartitionOrigin
+ 8: optional string iotConsensusV2Mode
Review Comment:
Please use 13 considering compatibility
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/SystemPropertiesUtils.java:
##########
@@ -53,6 +53,7 @@ public class SystemPropertiesUtils {
private static final String TIMESTAMP_PRECISION = "timestamp_precision";
private static final String CN_CONSENSUS_PROTOCOL =
"config_node_consensus_protocol_class";
private static final String DATA_CONSENSUS_PROTOCOL =
"data_region_consensus_protocol_class";
+ private static final String IOT_CONSENSUS_V2_MODE = "iot_consensus_v2_mode";
Review Comment:
this should be allowed to modify?
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template:
##########
@@ -154,10 +154,20 @@ data_replication_factor=1
# 1. org.apache.iotdb.consensus.simple.SimpleConsensus (The
data_replication_factor can only be set to 1)
# 2. org.apache.iotdb.consensus.iot.IoTConsensus
# 3. org.apache.iotdb.consensus.ratis.RatisConsensus
+# 4. org.apache.iotdb.consensus.ratis.IoTConsensusV2
# effectiveMode: first_start
# Datatype: string
data_region_consensus_protocol_class=org.apache.iotdb.consensus.iot.IoTConsensus
+# IoTConsensusV2 mode.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocol modes are currently supported:
+# 1. batch
+# 2. stream
+# effectiveMode: first_start
Review Comment:
restart？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
