OneSizeFitsQuorum commented on code in PR #13440: URL: https://github.com/apache/iotdb/pull/13440#discussion_r1764698121
########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -154,10 +154,20 @@ data_replication_factor=1 # 1. org.apache.iotdb.consensus.simple.SimpleConsensus (The data_replication_factor can only be set to 1) # 2. org.apache.iotdb.consensus.iot.IoTConsensus # 3. org.apache.iotdb.consensus.ratis.RatisConsensus -# effectiveMode: first_start +# 4. org.apache.iotdb.consensus.ratis.IoTConsensusV2 +# effectiveMode: restart Review Comment: first_start ########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -154,10 +154,20 @@ data_replication_factor=1 # 1. org.apache.iotdb.consensus.simple.SimpleConsensus (The data_replication_factor can only be set to 1) # 2. org.apache.iotdb.consensus.iot.IoTConsensus # 3. org.apache.iotdb.consensus.ratis.RatisConsensus -# effectiveMode: first_start +# 4. org.apache.iotdb.consensus.ratis.IoTConsensusV2 +# effectiveMode: restart # Datatype: string data_region_consensus_protocol_class=org.apache.iotdb.consensus.iot.IoTConsensus +# IoTConsensusV2 mode. +# This parameter is unmodifiable after ConfigNode starts for the first time. Review Comment: remove this line? ########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -1804,12 +1814,12 @@ schema_region_ratis_periodic_snapshot_interval=86400 data_region_ratis_periodic_snapshot_interval=86400 #################### -### Fast IoTConsensus Configuration +### IoTConsensusV2 Configuration #################### # Default event buffer size for connector and receiver in pipe consensus Review Comment: remove pipeconsensus ########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -154,10 +154,20 @@ data_replication_factor=1 # 1. org.apache.iotdb.consensus.simple.SimpleConsensus (The data_replication_factor can only be set to 1) # 2. org.apache.iotdb.consensus.iot.IoTConsensus # 3. org.apache.iotdb.consensus.ratis.RatisConsensus -# effectiveMode: first_start +# 4. org.apache.iotdb.consensus.ratis.IoTConsensusV2 +# effectiveMode: restart # Datatype: string data_region_consensus_protocol_class=org.apache.iotdb.consensus.iot.IoTConsensus +# IoTConsensusV2 mode. +# This parameter is unmodifiable after ConfigNode starts for the first time. +# These consensus protocol modes are currently supported: +# 1. batch +# 2. stream +# effectiveMode: first_start Review Comment: restart? BTW, Should we allow some nodes to stream and some nodes to batch? @SteveYurongSu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
