shuwenwei commented on code in PR #16643:
URL: https://github.com/apache/iotdb/pull/16643#discussion_r2468559966
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java:
##########
@@ -808,10 +962,19 @@ public boolean hasNextBatch() {
@Override
public TsBlock nextBatch() {
TSDataType dataType = getDataType();
- TsBlockBuilder builder = new
TsBlockBuilder(Collections.singletonList(dataType));
+ int maxRowCountOfCurrentBatch =
+ Math.min(
+ paginationController.hasLimit()
+ ? (int) paginationController.getCurLimit()
+ : Integer.MAX_VALUE,
+ Math.min(maxNumberOfPointsInPage, rows - index));
+ TsBlockBuilder builder =
+ new TsBlockBuilder(maxRowCountOfCurrentBatch,
Collections.singletonList(dataType));
switch (dataType) {
case BOOLEAN:
- while (index < rows && builder.getPositionCount() <
maxNumberOfPointsInPage) {
+ while (index < rows
+ && builder.getPositionCount() < maxNumberOfPointsInPage
Review Comment:
Deleting this judgment will cause TsBlockBuilder to load too much data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
