shuwenwei commented on code in PR #16643:
URL: https://github.com/apache/iotdb/pull/16643#discussion_r2468595040
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java:
##########
@@ -1632,33 +1635,41 @@ public TsBlock nextBatch() {
if (validRowCount >= maxNumberOfPointsInPage ||
isCurrentTimeExceedTimeRange(time)) {
break;
}
- // skip empty row
- if (allValueColDeletedMap != null
- &&
allValueColDeletedMap.isMarked(getValueIndex(getScanOrderIndex(index)))) {
- continue;
- }
- if (!isTimeSatisfied(time)) {
+ // skip invalid row
+ if ((allValueColDeletedMap != null
+ &&
allValueColDeletedMap.isMarked(getValueIndex(getScanOrderIndex(index))))
+ || !isTimeSatisfied(time)) {
+ timeInvalidInfo =
+ timeInvalidInfo == null
+ ? new LazyBitMap(index, maxRowCountOfCurrentBatch, rows - 1)
+ : timeInvalidInfo;
+ timeInvalidInfo.mark(index);
continue;
}
int nextRowIndex = index + 1;
while (nextRowIndex < rows
&& ((allValueColDeletedMap != null
&& allValueColDeletedMap.isMarked(
getValueIndex(getScanOrderIndex(nextRowIndex))))
- || !isTimeSatisfied(time))) {
+ ||
!isTimeSatisfied(getTime(getScanOrderIndex(nextRowIndex))))) {
Review Comment:
The old code has problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
