Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/7/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 1017: // TODO: So are we safe? yea, I think a test where you make sure that only alternating rows fall behind the AHM would be good. Most of the tests seem to fully remove or keep an entire DRS worth, so if the row_idx calculation is off, it won't catch it -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
