Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 704: // mutations that have only been partially applied? > yea, this is a bit tricky - I think it's OK because of the implementation o I spent a good while reading through the delta flush code path and my conclusion is that this is always safe because: 1. Scanners will be denied on timestamps < the AHM 2. Existing scanners hold the delta blocks open which allows them to maintain a consistent snapshot. I'll add a randomized test that provides coverage to verify that #2 holds true in the presence of history GC. -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
