Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC ......................................................................
Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/3076/12/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: Line 30: TEST_F(TabletHistoryGcItest, TestDeleteEmptyTable) { > I don't follow the name of this test. A comment explaining its intent would Ah, it was copypasta. I fixed it in a follow up commit (the randomized test CR) but now I've backported it to this commit. Line 33: // Insert some rows. > why do we need any rows for this test? I suppose we don't. Fixed. http://gerrit.cloudera.org:8080/#/c/3076/7/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 1017: // TODO: So are we safe? > yea, I think a test where you make sure that only alternating rows fall beh Done http://gerrit.cloudera.org:8080/#/c/3076/12/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 1017: // TODO: So are we safe? > Actually I'm worried about this... I think if you combine a "missed update" You were right and this was a problem after all. Added a test in the next rev of this CR called TestGcWithConcurrentCompaction that handles this case and I addressed the problem by plumbing a list of GCed input row offsets into ReupdateMissedDeltas(). I also added reupdating missed deltas into the randomized test that follows this patch. http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: Line 201: NO_FATALS(InsertOriginalRows(kNumRowSets, kRowsPerRowSet)); > can you add a test similar to TabletTest/TestGhostRowsOnDiskRowSets which e Done: TestGhostRowsNotRevived Line 262: // Mutate all of the rows. > as mentioned elsewhere, would be good to have a test which does major delta Done: TestMajorDeltaCompactionOnSubsetOfColumns -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
