Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker ......................................................................
Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/CMakeLists.txt File src/kudu/rpc/CMakeLists.txt: Line 121: ADD_KUDU_TEST(exactly_once_rpc-test) > Can you resort the tests? Done http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: PS17, Line 152: completion_record->state = RpcState::IN_PROGRESS; : completion_record->driver_attempt_no = request_id.attempt_no(); > Can we add these to the CR constructor? Done Line 232: completion_record->last_updated = MonoTime::Now(); > Technically we haven't mutated the CR, so why update its timestamp? yea, not sure, will remove. Line 348: completion_record->last_updated = MonoTime::Now(); > Likewise, shouldn't we push this down into where we actually update the CR? not convinced of this one -- if we moved it inside the loop, it might get updated multiple times, and no sense in wasting the extra clock calls. http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS17, Line 1247: // We only replay committed requests so the result of tracking this request can be: : // NEW - This is a previously untracked request, or we changed the driver -> store the result : // COMPLETED - We've bootstrapped this tablet twice, and previously stored the result -> do : // nothing. > Update this comment. Done http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: PS17, Line 227: VLOG(1) << state()->result_tracker() << " Follower Rpc was not NEW or IN_PROGRESS: " : << rpc_state << " OpId: " << state()->op_id().ShortDebugString() : << " RequestId: " << state()->request_id().ShortDebugString(); > Update this too? Should have been "not NEW or COMPLETED", I think. done. also changed to VLOG(2) since this is quite internal -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
