Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker ......................................................................
Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: Line 348: int64_t seq_no = request_id.seq_no(); > not convinced of this one -- if we moved it inside the loop, it might get u Yes, but what of the inverse: if MustHandleRpc==false for all ongoing RPCs, we're changing last_updated for a CR that didn't actually change. -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
