Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4164/7//COMMIT_MSG Commit Message: PS7, Line 25: 1M unique strings is this "dictionary encoded" column actually just falling back to 'plain' mode, though? http://gerrit.cloudera.org:8080/#/c/4164/7/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 312: CHECK_NOTNULL(sel); think this could be a DCHECK -- To view, visit http://gerrit.cloudera.org:8080/4164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
