Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/9/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 312: DCHECK_NOTNULL(sel); nit: this will actually give an "unused result" compiler warning. Should just be DCHECK(sel) -- To view, visit http://gerrit.cloudera.org:8080/4164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
