David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 98: name = "no_replica_table" > Since the test is setup up for 3 tservers today, if its ever increased/decr what I mean was to wrap this in something like "for num_replicas in [1,3,5]:" plus exercise the create table path a little more. That would cover that case even if we ever change the defaults (which we might do for test purposes or something). Line 111: self.client.delete_table(name) missed this before: why the double delete_table? -- To view, visit http://gerrit.cloudera.org:8080/4315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
