David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4315/4/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: Line 94 why delete this test? Line 93: def test_create_non_replicated_table(self): need to change the test name: something like: test_create_table_with_different_replication_factors Line 97: # number does not exceed the number of tservers nice, thanks for doing this. I completely forgot about the total number of tablet servers. I can follow on to try with higher replica numbers. Line 110: self.client.delete_table(name) why not just have the finally block, like before, and do a single delete_table there, independently of the assertion result? -- To view, visit http://gerrit.cloudera.org:8080/4315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
