Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at WARNING and above ......................................................................
Patch Set 1: (1 comment) TFTR Adar, please see below. http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: PS1, Line 215: // Set the verbosity of the commands to WARNING(2) and above. : // If the user had explicitly specified verbosity, then user's : // verbosity level is honored. Since '--v' depends on minloglevel : // specifying either of them on CLI will override this setting. : if (google::GetCommandLineFlagInfoOrDie("minloglevel").is_default && : google::GetCommandLineFlagInfoOrDie("v").is_default) { : google::SetCommandLineOption("minloglevel", : SimpleItoa(google::GLOG_WARNING).c_str()); : } > Couple of comments: 1. Done. 2. I was wondering if we want to keep the errors visible - for eg, if we run cluster ksck on a cluster which is partitioned, some RPC failures indicate(although not user-friendly output) that those hosts are not reachable. But this makes the output slightly less machine-readable. So keeping the level to FATAL for now, and let's decipher the status from the output itself rather than from error/warning logs. 3. When you say 'parameters', I am thinking about optional mode params(which could be gflags too in our case). But inheriting them means exposing all the ugly output of gflags help again, isn't it ? -- To view, visit http://gerrit.cloudera.org:8080/4447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
