Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: PS1, Line 215: FLAGS_minloglevel = google::GLOG_FATAL; : } : return show_help; : } : : int main(int argc, char** argv) { : bool show_help = ParseCommandLineFlags(&argc, &argv); : FLAGS_logtostderr = true; : k > I agree it's a little unusual looking, but given that many of the usages of One of the motivations of being less verbose here was to keep the output more machine-readable(I should update that in commit-message). Also binaries retrying on those RPC errors are difficult to apprehend for folks other than developers. Given that this tool may be used by support folks as well, we were inclining to go with default=quiet as opposed to default=verbose mode. -- To view, visit http://gerrit.cloudera.org:8080/4447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
