Todd Lipcon has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4512/1//COMMIT_MSG Commit Message: Line 14: and the @@GLIBCXX dependencies appear to be satisfied via libc++ somehow. definitely a little gross. How did you discover these dependencies so that this doesn't regress down the road if we add a new dependency? http://gerrit.cloudera.org:8080/#/c/4512/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: PS1, Line 83: sed -e ':loop' \ : -e 's/\(postdeps=.*\)\(-lstdc++\)/\1-lc++/' \ : -e 't loop' libtool > libtool.new : how about just using sed's regexp matching support, and also its backup file supprt? sed -i.before_fixup -e '/postdeps=/s/-lstdc++/-lc++/' libtool -- To view, visit http://gerrit.cloudera.org:8080/4512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id51c10d38984e892496621135634d21f3e2386ce Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
