Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: fix up libtool scripts if needed ......................................................................
thirdparty: fix up libtool scripts if needed Older versions of libtool (such as the version found on el6) do not pass -stdlib=libc++ found in CXXFLAGS down to the libtool link command line, and as a result, the shared object is linked against the system libstdc++. The net effect is that some thirdparty shared objects sprout @@GLIBCXX dependencies. Mysteriously, Kudu libraries and binaries themselves do not, and the @@GLIBCXX dependencies appear to be satisfied via libc++ somehow. Nevertheless, this is confusing and could prove problematic down the road, so here's a quick hack to "fix up" libtool scripts after they are generated via configure. Change-Id: Id51c10d38984e892496621135634d21f3e2386ce Reviewed-on: http://gerrit.cloudera.org:8080/4512 Reviewed-by: Dan Burkert <d...@cloudera.com> Tested-by: Dan Burkert <d...@cloudera.com> --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh A thirdparty/postflight.py 3 files changed, 136 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id51c10d38984e892496621135634d21f3e2386ce Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
