Adar Dembo has posted comments on this change. Change subject: thirdparty: split into dependency groups ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4513/1//COMMIT_MSG Commit Message: Line 29: "instrumented_msan" dependency group). > Will this actually work for msan, though? My understanding is that msan re You're probably right. I'm working on a follow-up patch that rebuilds the C dependencies for TSAN too. http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-if-necessary.sh File thirdparty/build-if-necessary.sh: PS1, Line 86: # > leftover Done Line 91: CHANGED_FILE_COUNT=$(find . -cnewer $STAMP_FILE | wc -l) > Consider adding '-type f' into the find options. If directory (especially I don't think it matters much either way. This case is so very rare (basically for developers who are annoyed at thirdparty rebuilds when testing out of a tarball install) that I don't think we need to optimize for a tarball whose contents actually changes. http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 363: build_protobuf > hmm. I think what this is saying, is that protobuf (and the others below) Yes, that's true, and it is something of a functional regression from before. But, I also think it's such a rarely used feature that it's not a huge deal either way. I only use "build-thirdparty.sh <lib>" on a fully-formed thirdparty tree when I want to rebuild a single library. We can certainly revisit this if there are complaints; it's relatively easy to adjust. -- To view, visit http://gerrit.cloudera.org:8080/4513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I549262858f98b5ce6c78e786e8c8d8134ba2ed36 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
