Jordan Birdsell has posted comments on this change. Change subject: [python] KUDU-1563. Add support for INSERT IGNORE ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4522/5/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: PS5, Line 164: self.assertRaises(Exception, session.apply, op) I think this test would now fail since the last write op will be an insert ignore. Maybe flip the insert ignore to be on even rows? PS5, Line 187: op = table.new_update() Is this supposed to be new_insert_ignore? -- To view, visit http://gerrit.cloudera.org:8080/4522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes