Dinesh Bhat has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/4412/12/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: PS12, Line 452: t of master a > The original approach was to be able to use any table structure, not only s Yeah, my comment at L457 was kinda related to this. i.e, I am not sure if we need to be flexible wrt schemas - we can have one static schema table and load generate and delete the table at the end of the test with an option to keep it if we want to append rows later. Basically when it comes to tests, one default approach could be 'leave_no_trace' philosophy. Imagine if I run this tool continuously for 100 times without exposing a button to delete the data generated from these tests, which means we are growing the data in unbounded fashion. PS12, Line 455: et > Yes, here and elsewhere in the description for parameters: this is intentio Other tools seem to have followed just one space, so was trying to be consistent with them. -- To view, visit http://gerrit.cloudera.org:8080/4412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
