Adar Dembo has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools ......................................................................
Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/4412/15/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: PS15, Line 108: ADD_KUDU_TEST(kudu-test) : ADD_KUDU_TEST_DEPENDENCIES(kudu-test : kudu) Why not reuse kudu-tool-test, which is where all of the new CLI tests (apart from the ported ones in kudu-ts-cli-test and kudu-admin-test) live? http://gerrit.cloudera.org:8080/#/c/4412/15/src/kudu/tools/kudu-test.cc File src/kudu/tools/kudu-test.cc: Line 37: These are nice, but can we at least verify that something was written with a scan? Can we verify an exact row count too? http://gerrit.cloudera.org:8080/#/c/4412/15/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: Line 110: #include "kudu/util/random.h" Nit: should precee stopwatch (surprised Tidy Bot didn't mention it?) PS15, Line 152: options allows " : "to keep Nit: option retains PS15, Line 156: is not in effect Nit: has no effect -- To view, visit http://gerrit.cloudera.org:8080/4412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
