Adar Dembo has posted comments on this change. Change subject: [c++ client] added few deprecation notes ......................................................................
Patch Set 1: (1 comment) Shouldn't we wait until the new API lands before deprecating the old one though? http://gerrit.cloudera.org:8080/#/c/4569/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 396: its Nit: "in signature". Or maybe just "or change in a future release" Do the same in the other methods, and in the @deprecated tags. -- To view, visit http://gerrit.cloudera.org:8080/4569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
