David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] added few deprecation notes ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4569/3/src/kudu/client/client.h File src/kudu/client/client.h: Line 386: /// The latest observed timestamp can be used to start a snapshot scan on a doesn't have to be in this patch, but it would be good to note that this comment is a "workaround" for RYW and that, as you found out, the user needs to add 1 to actually get the correct timestamp back. PS3, Line 1816: one of nit: s/one of/a -- To view, visit http://gerrit.cloudera.org:8080/4569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c45b797fa459ac9d214bb2612fd797f7a1eea45 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
