Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx File python/kudu/client.pyx: Line 812: del col_name_slice > Doesnt the try finally take care of this? Arent we essentially moving it by no, in this case dereferencing it would be a copy. Copy vs. move isn't really the important part; the bigger issue is that col_name_slice could be stack allocated, in which case you don't have to worry about deleting it at all. Copying and moving a slice are pretty much the same thing, since they don't own the data they point to. -- To view, visit http://gerrit.cloudera.org:8080/4548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
