Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/client.pyx File python/kudu/client.pyx: Line 768: len(self.name)) fixup indentation Line 822: len(self.name)) fixup indentation Line 824: vals.push_back(self.box_value(val)) If box_value throws a TypeError, will this leak the already constructed values in vals? http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: Line 77: def test_scan_rows_in_list_predicate(self): Could you add a test with mistyped values in the list, both that the python KuduValue converter can't handle (e.g. a python class for a string column), and also mistyped in terms of the wrong type for the column (e.g. int for a string column). -- To view, visit http://gerrit.cloudera.org:8080/4548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
