Jordan Birdsell has posted comments on this change. Change subject: KUDU-1611 - [python] Enable setting scanner selection policy ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4408/3/python/kudu/client.pyx File python/kudu/client.pyx: PS3, Line 1830: else: : try: : check_status(self._builder.SetSelection( : _replica_selection_policies[replica_selection.lower()])) : except KeyError: : invalid_selection_policy() > what is this trying to do? in which cases would this be hit? only if replic This gets hit if you scanner.set_selection('somethingweird'). Do you mean just let the KeyError happen? I figured since we already set up an error message for an invalid constant that we might as well give a consistent error here. http://gerrit.cloudera.org:8080/#/c/4408/3/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: PS3, Line 253: This test confirms that setting the scan selection policy on the : scanner does not cause any errors. There is no way to confirm : that the policy was actually set. > yeah this is a bummer. It's possible to do this but not without major work. Done -- To view, visit http://gerrit.cloudera.org:8080/4408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d9cd081c037e3284370943e2cae348476df26c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
