David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1611 - [python] Enable setting scanner selection policy ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4408/3/python/kudu/client.pyx File python/kudu/client.pyx: PS3, Line 1830: else: : try: : check_status(self._builder.SetSelection( : _replica_selection_policies[replica_selection.lower()])) : except KeyError: : invalid_selection_policy() > This gets hit if you scanner.set_selection('somethingweird'). Do you mean j oh, I missed that you were trying to support the enum and the dict. my bad, carry on. -- To view, visit http://gerrit.cloudera.org:8080/4408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d9cd081c037e3284370943e2cae348476df26c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
