Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL ......................................................................
Patch Set 1: (2 comments) This patch is a simple basic version of KuduRPC over SSL. There is some room for future work, and I think they should be done as separate patches once the general structure is decided upon. There are a couple of obvious flaws in this patch, and it would be great if I could get some help with those. I've added them as comments. http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 347: // TODO: Figure out a way to properly populate this. This is obviously wrong. Since there are no environment variables where I can source the path from, I'm not sure how to point the tests to the correct relative path. The auto gerrit tests will fail because of this. http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/util/net/ssl_socket.cc File src/kudu/util/net/ssl_socket.cc: Line 149: Status SSLSocket::Writev(const struct ::iovec *iov, int iov_len, Since there's no real writev() type support for SSL, this function breaks up the frames put together by SendBuffer() and sends them individually. So the buffering and un-buffering seem like a waste here. I'm not sure what a good solution is unless we subclass OutboundTransfer for the sake of SSL too, which seems a bit messy. -- To view, visit http://gerrit.cloudera.org:8080/4789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
