Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4874 to review the following change. Change subject: Remove unused code for checking PLAIN authentication ...................................................................... Remove unused code for checking PLAIN authentication This removes the 'AuthStore' abstraction which theoretically supported checking username/password authentication. In practice, we have no plans to implement our own username/password authentication any time soon, so this extra code just confuses the matter. Additionally, this deprecates the user information that's passed as part of the 'Connection Context'. The client still sends it, to satisfy older servers, but the server ignores it and instead determines user information from the SASL handshake. Change-Id: Ie960fae30fe573b859f7ef0e27d656faac50d4c2 --- M src/kudu/rpc/CMakeLists.txt D src/kudu/rpc/auth_store.cc D src/kudu/rpc/auth_store.h M src/kudu/rpc/connection.cc M src/kudu/rpc/negotiation.cc M src/kudu/rpc/outbound_call.cc M src/kudu/rpc/outbound_call.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/sasl_common.cc M src/kudu/rpc/sasl_common.h M src/kudu/rpc/sasl_rpc-test.cc M src/kudu/rpc/sasl_server.cc M src/kudu/rpc/sasl_server.h 14 files changed, 45 insertions(+), 261 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/4874/1 -- To view, visit http://gerrit.cloudera.org:8080/4874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie960fae30fe573b859f7ef0e27d656faac50d4c2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>