Todd Lipcon has posted comments on this change. Change subject: Remove unused code for checking PLAIN authentication ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4874/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 223: void WhoAmI(const WhoAmIRequestPB* req, WhoAmIResponsePB* resp, RpcContext* context) override { > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/4874/1/src/kudu/rpc/sasl_common.h File src/kudu/rpc/sasl_common.h: Line 107: static const char* name_of(Type val); > warning: function 'kudu::rpc::SaslMechanism::name_of' has a definition with Done http://gerrit.cloudera.org:8080/#/c/4874/1/src/kudu/rpc/sasl_server.cc File src/kudu/rpc/sasl_server.cc: Line 462: int SaslServer::PlainAuthCb(sasl_conn_t *conn, const char *user, const char *pass, > warning: parameter 'pass' is unused [misc-unused-parameters] Done Line 463: unsigned passlen, struct propctx *propctx) { > warning: parameter 'propctx' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/4874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie960fae30fe573b859f7ef0e27d656faac50d4c2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
