Matthew Jacobs has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 2: Alexey, thanks for doing this. As we discussed, one of the issues Impala faces is that the error codes are too coarse grained right now, so we can't differentiate some important error cases. I think this mechanism will be useful when it can also include breakdowns of the errors, more fine-grained than the error codes (which may need to remain as-is for backwards compatibility). However, until we can report the breakdown into more fine grained error stats, I don't think Impala will use this over the GetErrorStats, so it's up to you if you'd wanna still get this in in the meantime or shelve the change for later. -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
