David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4974/3//COMMIT_MSG Commit Message: PS3, Line 9: missing a word? "is"? PS3, Line 10: in the context s/in the context/during the lifetime PS3, Line 10: The stats are not reset : during the lifetime of a session. with the fix to the previous sentence I don't think you need this one (its implicit) http://gerrit.cloudera.org:8080/#/c/4974/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS3, Line 2686: EXPECT_EQ(1, session->total_write_ops()); : EXPECT_EQ(0, session->failed_write_ops()); Is it really interesting to be checking the stats in all these places? this will make changing these tests harder. Are we really measuring something useful? http://gerrit.cloudera.org:8080/#/c/4974/3/src/kudu/client/client.h File src/kudu/client/client.h: PS3, Line 1505: .. of _valid_/_successful_ invocations? PS3, Line 1518: and nit: s/and/or PS3, Line 1526: failed_write_ops( on a more general note: does it make sense to measure the failed calls to Apply()? At first glance I would think this would be interesting to measure Kudu client/server errors not API misusage, or did I miss something? -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
