David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: PS2, Line 35: type == UNDO ? "UNDO" : "REDO" > nit: consider using the DeltaType_Name() function here instead. Ah, good catch missed that. Done PS2, Line 36: Substitute("$0@tx$1" > The previous format had fixed width TX ids, which is more readable, IMHO. As I mention in the commit message, having no padding allows to grep logs for specific keys (like "key=1") which doesn't work with the padding as its different from everywhere else we print it. However padding is handy for other purposes so I ended up adding a flag and keeping both. http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/deltafile.cc File src/kudu/tablet/deltafile.cc: PS2, Line 612: (delta_type_ == DeltaType::REDO ? "REDO" : "UNDO") > Consider using DeltaType_Name() function instead. Done -- To view, visit http://gerrit.cloudera.org:8080/4930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc6c6ed76f5ab929c04410228d5ea70f4fc9660 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
