David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4930/3//COMMIT_MSG Commit Message: PS3, Line 12: changed > nit: changes Done http://gerrit.cloudera.org:8080/#/c/4930/3/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: PS3, Line 151: compaction flush > So which one is it? :) Done PS3, Line 173: " << " > nit: remove there, remove one ":" and replaced another one by "-" http://gerrit.cloudera.org:8080/#/c/4930/3/src/kudu/tablet/delta_store.h File src/kudu/tablet/delta_store.h: PS3, Line 112: If 'pad' is true pads > nit "is true, pads" or "is true it pads". I seem to be using commas a lot m Done PS3, Line 113: the result strings will compare as the delta keys themselves. > nit: rephrase this, a bit terse. I'm not even 100% sure what it means. Done -- To view, visit http://gerrit.cloudera.org:8080/4930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc6c6ed76f5ab929c04410228d5ea70f4fc9660 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
