Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 ......................................................................
Patch Set 7: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/4990/7/CMakeLists.txt File CMakeLists.txt: PS7, Line 855: include_directories(${KERBEROS_INCLUDE_DIR}) nit: if possible, consider adding this for relevant sources only (i.e. moving this directive into src/security/CMakeLists.txt). http://gerrit.cloudera.org:8080/#/c/4990/5/src/kudu/security/init.cc File src/kudu/security/init.cc: PS5, Line 88: > OK, new revision adds a test case which uses this new function outside of a Cool, thanks for verifying and fixing this! http://gerrit.cloudera.org:8080/#/c/4990/6/src/kudu/security/test/mini_kdc-test.cc File src/kudu/security/test/mini_kdc-test.cc: PS6, Line 20: #include <gflags/gflags.h> nit: consider using <gflags/gflags_declare.h> instead to have less header file dependencies. -- To view, visit http://gerrit.cloudera.org:8080/4990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708334cbbee35d2629a38a369e63c1dc309ed91b Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
