Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/7/CMakeLists.txt File CMakeLists.txt: PS7, Line 855: include_directories(${KERBEROS_INCLUDE_DIR}) > hm, but doesn't it already dedupe these? typically all of the libraries get If it's a custom location (like in third-party), there is nothing do dedupe here. In that case, for most sources, that -I <custom kerberos dir> is not needed at all. -- To view, visit http://gerrit.cloudera.org:8080/4990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708334cbbee35d2629a38a369e63c1dc309ed91b Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
