David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS3, Line 823: 3 > Not a review comment per se, was it intentional to keep Input row loglevel No, didn't really change it, but it does make sense to keep them together. Changed both to 4 since this is very verbose PS3, Line 1073: LOG_STRING(INFO, lines) << schema->DebugRow(input_row.row) << : " Undos: " + Mutation::StringifyMutationList(*schema, input_row.undo_head) << : " Redos: " + Mutation::StringifyMutationList(*schema, input_row.redo_head); > Does it make sense to use one of the new functions here as well? It does. good catch. done http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.h File src/kudu/tablet/compaction.h: PS3, Line 235: Mutation* undo_head > const Muntation* undo_head Done PS3, Line 235: Mutation* redo_head > const Mutation* read_head Done -- To view, visit http://gerrit.cloudera.org:8080/4988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
