David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS3, Line 1073: LOG_STRING(INFO, lines) << schema->DebugRow(input_row.row) << : " Undos: " + Mutation::StringifyMutationList(*schema, input_row.undo_head) << : " Redos: " + Mutation::StringifyMutationList(*schema, input_row.redo_head); > It does. good catch. done Ended up reverting this. Turns out a bunch of tests rely on this being printed in this exact format. A fight for another day :) -- To view, visit http://gerrit.cloudera.org:8080/4988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
