David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc File docs/developing.adoc: PS3, Line 56: generatess typo PS3, Line 61: backend missing period at the end of sentence PS3, Line 160: much s/much/part PS3, Line 170: to be used to create a new s/all of this/for a new PS3, Line 205: table.new_delete({'key': 2}) q can we do more than one of these within a session.apply()? If so can you use an example? If not do we really need the weird wrapping or is this idiomatic python that I'm missing. PS3, Line 209: session.flush() I forget do all of these raise exceptions or do they return a status. If its the latter can you assign it/use it? PS3, Line 216: # Open Scanner and read all tuples Add a note that this doesn't scale for huge scans -- To view, visit http://gerrit.cloudera.org:8080/4586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jtbirds...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jtbirds...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
