Jordan Birdsell has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc
File docs/developing.adoc:

PS3, Line 56: generates 
> typo
Done


PS3, Line 61: backend
> missing period at the end of sentence
Done


PS3, Line 160: part
> s/much/part
Done


PS3, Line 170: for a new table
> s/all of this/for a new
Done


PS3, Line 205: 
> q can we do more than one of these within a session.apply()? If so can you 
Changed, however, you bring up a good point, enabling a list of writeops might 
be nice to have in the future


PS3, Line 209: 
> I forget do all of these raise exceptions or do they return a status. If it
it does, gives you the "some errors occured" error. Added a try except block to 
demonstrate that.


PS3, Line 216: # Note: This doesn't scale for lar
> Add a note that this doesn't scale for huge scans
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to