Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/local_tablet_writer.h File src/kudu/tablet/local_tablet_writer.h: Line 96: CHECK_OK(SchemaToPB(*client_schema_, req.mutable_schema())); hrm, we have some benchmarks based on LocalTabletWriter IIRC -- this might be a negative perf change on the benchmarks. I guess the reason you did this is because now all of the threads share the same LocalTabletWriter instance? but really all they need to share is the lock_ simulating the single-threaded prepare, right? might be worth considering plumbing such a lock in instead of sharing the LocalTabletWriter instances, since LocalTabletWriter does a nice job of encapsulating the junk like TxResultPB which you've had to expose now PS3, Line 118: Since this a "local" tablet writer it shouldn't care about "safe" : // time, which is a distributed concept. per my comment on the other commit, I'm a little nervous that there is some interaction between safe time and compaction snapshots, and we don't have a lot of tests which try to really stress compaction on a follower which might have transactions arriving during the various phases. http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: Line 68: void InsertOriginalRows(LocalTabletWriter* writer, int num_rowsets, uint64_t rows_per_rowset); can the writer just be a member variable set up in the ctor or Setup method? seems like they're all initialized the same way -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
