David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests ......................................................................
Patch Set 3: (2 comments) thanks for the input all. I've swapped this for a much less intrusive approach that only changes the tablet method and doesn't touch LocalTabletWriter. http://gerrit.cloudera.org:8080/#/c/5056/3//COMMIT_MSG Commit Message: PS3, Line 7: - > nit: may be, remove those extra symbols? historically we've used these, but changed it to : and got rid of a space. (actually abandoned this patch but did it for the other ones). http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 372: DCHECK(!tx_state->has_timestamp()); > might as well use a CHECK if this is only for tests Done -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
