Adar Dembo has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: PS1, Line 30: ${KRB5_REALM_OVERRIDE} : krb5) If the ordering is critical (as I think it is, based on your commit description), we should document that. http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/test/krb5_realm_override.cc File src/kudu/security/test/krb5_realm_override.cc: We should move this out of the 'test' subdirectory so it's not confusing when it's found linked to a production binary. PS1, Line 32: The linkage invocation uses the '-Wl,--undefined' : // linker flag to force linking even though no symbol here is explicitly : // referenced. Now that this is expected to be found in every Kudu binary, you could add a no-op symbol that is referenced out of ServerBase/TestMain (etc.) to avoid using -Wl,--undefined, no? -- To view, visit http://gerrit.cloudera.org:8080/5100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I050d03d58658b650891566b9f955c867b15731e0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
