Adar Dembo has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/4//COMMIT_MSG Commit Message: PS4, Line 32: important executables (tserver, master, and 'kudu' tool) What about one-off executables like tpch, tpch_real_world, etc? And the client library (which is to say, third party applications that use the client library)? I presume the answer is 'no' because it's not important for them to work under the following conditions: 1) el6 (i.e. old krb5), and 2) numeric IPs in service principals, and 3) no functional reverse DNS for those IPs. http://gerrit.cloudera.org:8080/#/c/5100/4/CMakeLists.txt File CMakeLists.txt: PS4, Line 945: Binaries which are used by tests need to link this in. Can you update this to be very precise about what kind of binaries need it? It's not just tests, since it's also being used in the daemons. What's the rule of thumb? Binaries that use krpc to communicate with a mini cluster as part of an integration test? http://gerrit.cloudera.org:8080/#/c/5100/4/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 22: target_link_libraries(krb5_realm_override glog dl) I don't think we want to link libdl on macOS. -- To view, visit http://gerrit.cloudera.org:8080/5100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I050d03d58658b650891566b9f955c867b15731e0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
