Alexey Serbin has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens ......................................................................
Patch Set 1: > did you test that these tokens are cross-client compatible? Nope, that I didn't do. I assumed that's guaranteed by the ProtoBuffer format as is. Or you mean some sort of artificial constraints in the serialization/de-serialization logic in Java and C++ client? We could implement a test for the latter as well (if it does not exist). I would vote for doing that, but I think it's better to do that in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/5220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c76c20b62cb91695c69f7dc4b98f4dc98bf02cc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No