Dan Burkert has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5220/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: Line 328: // latest observed timestamp of the client object missing period. Line 330: // When creating serialized scan tokens, redundant paragraph? Line 366: const uint64_t ts_prev = client_->GetLatestObservedTimestamp(); Is this going to 'break' the client for subsequent tests? -- To view, visit http://gerrit.cloudera.org:8080/5220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c76c20b62cb91695c69f7dc4b98f4dc98bf02cc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
