Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5248/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS1, Line 214: protected synchronized long getLastPropagatedTimestamp() > the whole point of the lpt is that users can use message passing to get lin All right, that makes sense to me. Probably, the way we pass information about the last observed (propagated) timestamp would change, but at least we need to have some parity between the clients. http://gerrit.cloudera.org:8080/#/c/5248/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: PS1, Line 806: -1 > use the constant? Done -- To view, visit http://gerrit.cloudera.org:8080/5248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d45ba395f2a3fc6b54591f4a45bb4f10435910 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
