David Ribeiro Alves has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans ......................................................................
Patch Set 2: (2 comments) lgtm just a couple of verbage nits. feel free to push after fixing. http://gerrit.cloudera.org:8080/#/c/5248/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java: PS2, Line 209: the propagated timestamp should be received. nit avoid should, nit, rephrase to: "so the client should have received the propagated timestamp in the scanner response" PS2, Line 217: bring nit: s/bring/move s/the timestamp/the propagated timestamp -- To view, visit http://gerrit.cloudera.org:8080/5248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d45ba395f2a3fc6b54591f4a45bb4f10435910 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes