Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some low-hanging-fruit optimizations on write path ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5195/5//COMMIT_MSG Commit Message: Line 9: Rather than adding an element at a time and calling the virtual > gvint_block.cc is doing something very similar. Perhaps it would be good t I think gvint is basically dead except for test codepaths, since it's only usable for UINT32, and users can't specify uint32 anymore http://gerrit.cloudera.org:8080/#/c/5195/5/src/kudu/cfile/bshuf_block.h File src/kudu/cfile/bshuf_block.h: PS5, Line 93: OVERRIDE > nit: here and elsewhere in this file: consider replacing the macro with 'ov would rather do this separately Line 174: return kHeaderSize + count_ * size_of_type; > Why don't we round up this estimate anymore? not worth it to improve estimate by ~30 bytes max -- To view, visit http://gerrit.cloudera.org:8080/5195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia895f7731e5371967782ef9cb176a9d493894a83 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
